RE: [PHP-DEV] Pull request labels handling
| From: | Anatol Belski | Date: | Wed, 27 May 2015 16:10:16 +0000 |
| Subject: | RE: [PHP-DEV] Pull request labels handling | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-86405@lists.php.net to get a copy of this message | ||
Hi,
> -----Original Message-----
> From: Xinchen Hui [mailto:laruence@php.net]
> Sent: Wednesday, May 27, 2015 5:25 PM
> To: Hannes Magnusson
> Cc: Anatol Belski; Internals
> Subject: Re: [PHP-DEV] Pull request labels handling
>
> On Wed, May 27, 2015 at 10:27 PM, Hannes Magnusson
> <hannes.magnusson@gmail.com> wrote:
> > On Wed, May 27, 2015 at 6:29 AM, Anatol Belski <anatol.php@belski.net>
> wrote:
> >> Hi,
> >>
> >> the PRs on github are already being labeled. Multiple labels are possible.
> >> However the github ACLs lack on granularity
> >>
> >> https://help.github.com/articles/permission-levels-for-an-organizatio
> >> n-repos itory/ . Due to that, while being a useful feature, labeling
> >> is only available for project admins or alike. Now with PHP7 such
> >> labeling becomes probably even more sense as we'll need to handle BC
> >> breaks and other situations which would need more testing and care.
> >> So the amount of work to evaluate and review PRs will grow while the
> >> "work team" probably not.
> >
> >
> > I don't have time to work on qa.php.net/pulls and add such feature, so
> > I gave Xinchen and Nikita admin rights for the organization as a
> > workaround. Stas was already an admin.
> >
> > We did mention that if labelling is supposed to be integral part of
> > the workflow this must be available for the normal karma holder and
> > therefore needs to be integrated somehow.
> Github expose such apis already
> https://developer.github.com/v3/issues/#edit-an-issue
>
> so I think it's not very difficult to add such features to qa.php.net/pulls now.
>
> any volunteer ? if no, I can work on it this weekend... hope I didn't forget
> my experience on jquery :)
>
>
I can take this, maybe to qa.php.net/pulls first were easier. Then bugs.php.net if it's found
useful useful. Will need to refresh the jquery status as well :)
Regards
Anatol