Re: Pull request labels handling
| From: | Christoph Becker | Date: | Wed, 27 May 2015 23:17:11 +0000 |
| Subject: | Re: Pull request labels handling | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-86415@lists.php.net to get a copy of this message | ||
Anatol Belski wrote:
> the PRs on github are already being labeled. Multiple labels are possible.
> However the github ACLs lack on granularity
>
> https://help.github.com/articles/permission-levels-for-an-organization-repos
> itory/ . Due to that, while being a useful feature, labeling is only
> available for project admins or alike. Now with PHP7 such labeling becomes
> probably even more sense as we'll need to handle BC breaks and other
> situations which would need more testing and care. So the amount of work to
> evaluate and review PRs will grow while the "work team" probably not.
>
> To improve this, here's an idea originally coming from Ferenc. And it is
> simple - the labeling feature could be integrated with our systems using the
> github API. That would allow to achieve more granularity on who is allowed
> to label. AFAIR there was already some people willing to do labeling, so
> that were a great possibility to build such a team. Such pre evaluating and
> labeling could possibly prevent some awkward situations, help to sort out
> potential issues and BC breaches.
>
> Thus asking for opinions. As it stands completely open - does this idea
> sound eligible, how can it be integrated, who is yet up for the pre
> evaluation/labeling job? Or any other propositions.
In my humble opinion it would be great if it's feasible. There is also
the related "GitHub Pull Requests Triage Team" RFC[1] – maybe it's worth
to revive it, but it appears to me all this can be done without an
(approved) RFC.
[1] <https://wiki.php.net/rfc/github-pr>
--
Christoph M. Becker