Re: [RFC] Throwable Interface
| From: | Levi Morrison | Date: | Tue, 09 Jun 2015 18:13:56 +0000 |
| Subject: | Re: [RFC] Throwable Interface | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-86529@lists.php.net to get a copy of this message | ||
On Tue, Jun 9, 2015 at 11:40 AM, Aaron Piotrowski <aaron@icicle.io> wrote:
> Does anyone have any questions, comments, or concerns about the Throwable Interface RFC?
>
> http://wiki.php.net/rfc/throwable-interface
>
> The proposed exception hierarchy:
>
> interface Throwable
> ⊢ Exception implements Throwable
> ∟ Error implements Throwable (replaces EngineException)
> ⊢ TypeError (replaces TypeException)
> ∟ ParseError (replaces ParseException)
>
> I’d like to complete a vote before too many alpha releases are made.
>
> I’ll be happy to resolve the merge conflicts in the PR if the vote passes.
My only objections have already been raised, but I'll reiterate them briefly:
1. Having both Error and Exception makes little sense, especially
since we have historically used error to refer to an error that wasn't
an exception (something that triggered the error handler).
2. The name "Error" is going to have a fairly high collision rate
with user code.
3. I think they should all use Exception as the root instead having
a new root with multiple children (and yes, I am aware of the impact
of this, and it has already been discussed on this list).