Re: [RFC] Throwable Interface
| From: | Dmitry Stogov | Date: | Mon, 15 Jun 2015 21:58:17 +0000 |
| Subject: | Re: [RFC] Throwable Interface | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-86687@lists.php.net to get a copy of this message | ||
I think REGISTER_INTERFACE() macro in zend_interfaces.h is better.
Actually, it's not related to ITERATORs at all.
Thanks. Dmitry.
On Tue, Jun 16, 2015 at 12:48 AM, Aaron Piotrowski <aaron@icicle.io> wrote:
>
> On Jun 15, 2015, at 9:53 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
> On Mon, Jun 15, 2015 at 4:55 PM, Aaron Piotrowski <aaron@icicle.io> wrote:
>
>
> On Jun 15, 2015, at 6:56 AM, Anatol Belski <anatol.php@belski.net> wrote:
>
> Would you like me to move zend_ce_throwable to zend_exceptions.h/c or is
> that
> something you’d take care of after the merge?
>
>
> I don't care about this a lot. I just think it's better.
> If you don’t see any problems, please, move the code.
>
>
> Moving the definition of zend_ce_throwable to zend_exceptions.h/c
> requires either:
>
> 1. Moving #define REGISTER_ITERATOR_INTERFACE from
> zend_interfaces.c to zend_interfaces.h so it is available in
> zend_exceptions.c (I could take the opportunity to rename this macro
> to REGISTER_INTERFACE).
>
> 2. Defining a macro in zend_exceptions.c that is identical to
> REGISTER_ITERATOR_INTERFACE.
>
> Which option sounds better?
>
> Aaron Piotrowski
>