Re: [RFC] Throwable Interface

Hi, I made a quick code review, and I don't see any technical problems in implementation. 1) Anyway, I think it's a bad idea to rename "EngineException" (and others) into "Error"(s). This will prevent using class "Error" in applications, and may potentially break some of them. I also don't like renaming in ~440 tests (I didn't review all these changes). 2) I think it's better to move "zend_ce_throwable" definition/initialization from zend_interfaces.h/c into zend_exception.h/c. At least, this will allow arg_info reuse. (it's missed now, but should be added now or in the future). 3) In ext/simplexml/tests/SimpleXMLElement_xpath_3.phpt EngineExcpetion is not renamed into Error. Thanks. Dmitry. On Sun, Jun 14, 2015 at 8:24 PM, Aaron Piotrowski <aaron@icicle.io> wrote: > > > On Jun 14, 2015, at 11:31 AM, Anatol Belski <anatol.php@belski.net> > wrote: > > > > Hi Dmitry, > > > > > > > > I would go by accepting this. Furthermore – if you feel that the > implementation is stable enough and does not BC, I would suggest to have it > already in the alpha2. > > > > > > > > As there seems to be at all no resistance in the votes (no even single > “no” voter yet), nor strong objection here on the lists. The minimal > voting period is 1 week, so theoretically if it were ended on Wed (the > voting RFC doesn’t disallow this) – there were still some time to do > extensive testing and fixes. Alpha2 is the time where a) a lot of users > will be able to test it and b) it still can be reverted in the worst case.. > > > > > > > > What do you think? > > > > > > > > Regards > > > > > > > > Anatol > > > > I will have some time to resolve the merge conflicts later today, so I > will be happy to take care of that. > > Regards, > Aaron Piotrowski > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >