Re: limit for mmaping for readfile (Bug #19749)
| From: | Derick Rethans | Date: | Wed, 21 Apr 2004 11:49:30 +0000 |
| Subject: | Re: limit for mmaping for readfile (Bug #19749) | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-9462@lists.php.net to get a copy of this message | ||
On Wed, 21 Apr 2004, Andi Gutmans wrote:
> >My patch is "nice" at this stage in the release because it is a
> >minimal change that can't hurt anything; tweaking the passthru
> >code is a bit more worrying :/
>
> In that case, I'd put a hardcoded limit after which you fallback to
> non-mmap()'ed reading and not add an INI option. Then you can add the
> tweaked code when you have time/energy.
I would go for an INI setting because I can imagine situations were
you'd want to even lower this (hardcoded) 8MB limit to say 1MB before
falling back to non-mmap code.
Derick