Re: limit for mmaping for readfile (Bug #19749)

At 08:46 AM 4/21/2004 -0400, Ilia Alshanetsky wrote:

On April 21, 2004 05:52 am, Andi Gutmans wrote: I have played with mmap() in the past. I found that mapping in relatively small blocks such as 1MB does not really hurt performance. I suggest not to add yet another INI option but to do it with smaller blocks. I think even 256KB wouldn't make a big difference. I whole heartedly agree with Andi about not adding more INI options, but perhaps we could add a configure time option. This would give admins whose servers have plenty of ram and/or need to open a slightly larger then 1 meg files the ability to control this limit.

I don't see why. 1MB should work OK (it will fallback to regular file reading if it's above this). Wez will fix his code to work better with mmap() at a later time. No reason to add options for something which will be fixed. Andi