Re: limit for mmaping for readfile (Bug #19749)
| From: | Andi Gutmans | Date: | Thu, 22 Apr 2004 05:56:37 +0000 |
| Subject: | Re: limit for mmaping for readfile (Bug #19749) | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-9481@lists.php.net to get a copy of this message | ||
It's not a big deal, but I don't see why we should add a configure option if it's something which we'll remove the minute Wez has some more spare time and improves the implementation.
At 01:40 AM 4/22/2004 +0200, Marcus Boerger wrote:
Hello Andi, i still cannot say any reason against a configure option here? marcus Wednesday, April 21, 2004, 1:42:00 PM, you wrote: For now make it like 4MB. When you fix it to mmap() parts of the file I'd use 256 or 512KB. Andi At 12:38 PM 4/21/2004 +0100, Wez Furlong wrote:-- Best regards,Which brings us back to the original problem ;) How big should the limit be? --Wez.In that case, I'd put a hardcoded limit after which you fallback to non-mmap()'ed reading and not add an INI option. Then you can add the tweaked code when you have time/energy. AndiMarcus mailto:helly@php.net