Re: [PATCH] fix pcre global variable abuse
| From: | Ilia Alshanetsky | Date: | Fri, 23 Apr 2004 14:05:53 +0000 |
| Subject: | Re: [PATCH] fix pcre global variable abuse | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-9500@lists.php.net to get a copy of this message | ||
On April 23, 2004 10:01 am, Andi Gutmans wrote:
> I think changing back to malloc/free on RSHUTDOWN is a better solution.
> After all, we use our memory manager to prevent memory leaks and I think
> this is one of PHP's most important features. I don't trust third party
> extensions :)
The php_pcre_(free|malloc) use persistent allocation routines with the
persistent flag set. Iif I am reading the code correctly, this is nothing
more then a wrapper around malloc() free() without any sort of ZE memory
management. If that is indeed the case, it would seem that Joe's solution
would be better, since besides fixing the problem it eliminates pointless
wrapper.
Ilia