Re: [PATCH] fix pcre global variable abuse

From: Date: Fri, 23 Apr 2004 17:07:03 +0000
Subject: Re: [PATCH] fix pcre global variable abuse
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to internals+get-9516@lists.php.net to get a copy of this message
i'm pretty sure it does, it has a compiled regex cache that uses it, i think. -sterling On Apr 23, 2004, at 7:11 AM, Andi Gutmans wrote:
At 10:05 AM 4/23/2004 -0400, Ilia Alshanetsky wrote:
On April 23, 2004 10:01 am, Andi Gutmans wrote:
I think changing back to malloc/free on RSHUTDOWN is a better
solution.
After all, we use our memory manager to prevent memory leaks and I
think
this is one of PHP's most important features. I don't trust third
party
extensions :)
The php_pcre_(free|malloc) use persistent allocation routines with the persistent flag set. Iif I am reading the code correctly, this is nothing more then a wrapper around malloc() free() without any sort of ZE memory management. If that is indeed the case, it would seem that Joe's solution would be better, since besides fixing the problem it eliminates pointless wrapper.
I was sure it was using emalloc/efree. Is there any good reason it isn't? Does PCRE require persistent memory? If it does, then I agree with you that malloc/free is the right way to go. Andi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php


« previous php.internals (#9516) next »