Re: [RFC][DISCUSSION] Improve uniqid() uniqueness

Hi, > This is RFC for improving uniqid() uniqueness. > https://wiki.php.net/rfc/uniqid > > PR > https://github.com/php/php-src/pull/2123 > > If there is anything left to discuss, please comment. I think uniqid() should not be changed in BC break way, it should be left as is. You said, >> Almost all uniqid() usages do not care about return value chars nor >> length. Therefore, BC will be minimum. >> >> >> https://searchcode.com/?q=uniqid&loc=0&loc2=10000&lan=24 but you may be underestimating. I found that some code saved output of uniqid() without more_entropy to DB, in the search results. Output length change may cause problem in such case. And you are not supposed to forget that most of php codes are not open source and not opened to the public. In addition, you shoud hear "I expect the numbers to grow" about output of uniqid(), as reply to you. -- Kazuo Oishi