Re: Re: [RFC][DISCUSSION] Improve uniqid() uniqueness

2016-10-18 14:02 GMT+02:00 Yasuo Ohgaki <yohgaki@ohgaki.net>: > Hi Joe, > > On Tue, Oct 18, 2016 at 8:30 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote: > > > > On Tue, Oct 18, 2016 at 7:32 PM, Joe Watkins <pthreads@pthreads.org> > wrote: > >>> This change should go through the standard RFC process and should be > >>> targeted at 7.2+ (master) *only*. > >> > >>> Please check with the RMs before merging functionality changes into > >>> release > >>> branches. All functionality changes need consent and consensus. Bug > fixes > >>> (that don't change functionality or break BC) do not. > >> > >> You were told very specifically that the kinds of changes you proposed > here > >> require an RFC. > > > > This comment is for original proposal that _changes_ output format, > isn't it? > > > > It simply switches entropy source which we already relied on. > > As you can see from last minutes discussion. > > "/dev/urandom cannot be read" is FUD. > It's pure bug fix. (I intentionally made patch easy to extend used > chars, though) > > Would you consider revert the revert? > This discussion shows there should be a RFC and a vote. I'd not consider this a simple bug fix, after all it doesn't really fix it. If we want to fix it in core, we'd better include an UUID generation mechanism than fixing uniq_id. Regards, Niklas > Thanks. > > -- > Yasuo Ohgaki > yohgaki@ohgaki.net > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >