Re: Re: [RFC][DISCUSSION] Improve uniqid() uniqueness
| From: | Yasuo Ohgaki | Date: | Tue, 18 Oct 2016 12:02:57 +0000 |
| Subject: | Re: Re: [RFC][DISCUSSION] Improve uniqid() uniqueness | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-96430@lists.php.net to get a copy of this message | ||
Hi Joe,
On Tue, Oct 18, 2016 at 8:30 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
> On Tue, Oct 18, 2016 at 7:32 PM, Joe Watkins <pthreads@pthreads.org> wrote:
>>> This change should go through the standard RFC process and should be
>>> targeted at 7.2+ (master) *only*.
>>
>>> Please check with the RMs before merging functionality changes into
>>> release
>>> branches. All functionality changes need consent and consensus. Bug fixes
>>> (that don't change functionality or break BC) do not.
>>
>> You were told very specifically that the kinds of changes you proposed here
>> require an RFC.
>
> This comment is for original proposal that _changes_ output format, isn't it?
>
> It simply switches entropy source which we already relied on.
As you can see from last minutes discussion.
"/dev/urandom cannot be read" is FUD.
It's pure bug fix. (I intentionally made patch easy to extend used
chars, though)
Would you consider revert the revert?
Thanks.
--
Yasuo Ohgaki
yohgaki@ohgaki.net