Re: Re: Improving mt_rand() seed

Hi Lauri, On Thu, Jan 19, 2017 at 1:06 AM, Lauri Kenttä <lauri.kentta@gmail.com> wrote: > On 2017-01-18 08:04, Yasuo Ohgaki wrote: > >> Lauri, >> You wrote the patch. Could you make Pull Request to github's php-src >> repo?If you prefer not to, I'll make the PR. >> >> I think your patch should be applied from PHP-7.0 branch. >> > > I've revised my patch (added GENERATE_SEED() fallback), see [1]. I can > send that against master if the approach is accepted here. If you want it > in PHP-7.0 or PHP-7.1, please merge it yourself, thank you. > > [1] https://github.com/Metabolix/php-src/tree/mt_srand_auto-pr Thank you. I have to be able to modify patch, so I'll fetch your change to my repo and make PR. BTW, I don't think we have to care for failing CSPRNG. If it failed, application should fail properly, i.e. should terminate process/code. PHP apps are not OS nor DBMS, they have freedom to terminate/exit when fatal event happened. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net