Re: Bug interface
| From: | Jeroen van Wolffelaar | Date: | Sat, 07 Jul 2001 18:55:45 +0000 |
| Subject: | Re: Bug interface | ||
| References: | 1 | Groups: | php.mirrors |
| Request: | Send a blank email to php-mirrors+get-5293@lists.php.net to get a copy of this message | ||
> On Sat, Jul 07, 2001 at 05:57:21PM +0200, Jeroen van Wolffelaar wrote:
> > Err, you're right... bugs.php is quite hard to read, shouldn't the
phpweb
> > code be a good example for everyone ;)?
>
> patches would be gladly accepted. i think it was even worse before i
> took a chainsaw to it (modulo some new bugs). the one section i
> haven't cleaned up is the 'display' section. (while the table_wrapper
> stuff may be an interesting abstraction, i think it is overkill.)
You're right, it was worse... a typical example of something that started
out simple, but because of patch over patch, and hack over hack, got
unreadable...
Introducion those functions is a leap ahead :).
Personally, I think it's better to have functions AFTER the global logic.
And behind a clear comment: aid-functions starting here.
About the missing ?>: I do that all the time, it's valid. Though not clearly
documented... that's a TODO then...
I think Goba is working on it? Or should I try to clean it up (i.e. rewrite
the structure, and maybe rewrite half of it...)
> jim
Greetz,
Jeroen