Re: cvs: pear /PEAR_Command_Packaging/tests/make-rpm-spec test1.out test1.phpt test_option_rpm-depname.out test_option_rpm-depname.phpt
test_option_rpm-pkgname.out test_option_rpm-pkgname.phpt test_option_rpm-release.out test_option_rpm-release.phpt
| From: | Greg Beaver | Date: | Thu, 16 Feb 2006 16:32:27 +0000 |
| Subject: | Re: cvs: pear /PEAR_Command_Packaging/tests/make-rpm-spec test1.out test1.phpt test_option_rpm-depname.out test_option_rpm-depname.phpt test_option_rpm-pkgname.out test_option_rpm-pkgname.phpt test_option_rpm-release.out test_option_rpm-release.phpt |
||
| References: | 1 | Groups: | php.pear.cvs |
| Request: | Send a blank email to pear-cvs+get-38281@lists.php.net to get a copy of this message | ||
Tim Jackson wrote:
> timj Wed Feb 15 17:24:10 2006 UTC
>
> Added files:
> /pear/PEAR_Command_Packaging/tests/make-rpm-spec test1.out
> test1.phpt
> test_option_rpm-depname.out
> test_option_rpm-depname.phpt
> test_option_rpm-pkgname.out
> test_option_rpm-pkgname.phpt
> test_option_rpm-release.out
> test_option_rpm-release.phpt
> Log:
> Add some unit tests. Source file (Net_SMTP-1.2.8.tgz) for these currently needs to be
> manually put in the packagefiles/ dir
>
>
>
> ------------------------------------------------------------------------
>
>
>
> http://cvs.php.net/viewcvs.cgi/pear/PEAR_Command_Packaging/tests/make-rpm-spec/test1.out?view=markup&rev=1.1
> Index: pear/PEAR_Command_Packaging/tests/make-rpm-spec/test1.out
> +++ pear/PEAR_Command_Packaging/tests/make-rpm-spec/test1.out
Hi Tim,
The .out files should not be committed to cvs, and in fact, you probably
want a .cvsignore with this contents in the tests/ directory:
*.out
*.diff
*.php
*.exp
*.log
These are all auto-generated files. Instead, what you would do is save
the expected .spec output in the packagefiles dir, and compare the
contents....
>
> http://cvs.php.net/viewcvs.cgi/pear/PEAR_Command_Packaging/tests/make-rpm-spec/test1.phpt?view=markup&rev=1.1
> Index: pear/PEAR_Command_Packaging/tests/make-rpm-spec/test1.phpt
> +++ pear/PEAR_Command_Packaging/tests/make-rpm-spec/test1.phpt
> $phpunit->assertFileExists($temp_path . DIRECTORY_SEPARATOR . 'SPECS' .
> DIRECTORY_SEPARATOR . 'PEAR::Net_SMTP-1.2.8.spec', 'spec file');
> $phpunit->assertEquals(file_get_contents('test1.out'),
> file_get_contents($temp_path .
> DIRECTORY_SEPARATOR . 'SPECS' .
> DIRECTORY_SEPARATOR . 'PEAR::Net_SMTP-1.2.8.spec'), 'spec file
> contents');
here with:
$phpunit->assertEquals(file_get_contents(dirname(__FILE__) .
DIRECTORY_SEPARATOR . 'packagefiles' . DIRECTORY_SEPARATOR .
'PEAR::Net_SMTP-1.2.8.spec', file_get_contents($temp_path .
DIRECTORY_SEPARATOR . 'SPECS' .
DIRECTORY_SEPARATOR . 'PEAR::Net_SMTP-1.2.8.spec'), 'spec file
contents');
Greg