Re: cvs: pear /PEAR_Command_Packaging/tests/make-rpm-spec test1.outtest1.phpt test_option_rpm-depname.out test_option_rpm-depname.phpt
test_option_rpm-pkgname.outtest_option_rpm-pkgname.phpt test_option_rpm-release.out test_option_rpm-release.phpt

From: Date: Thu, 16 Feb 2006 17:14:10 +0000
Subject: Re: cvs: pear /PEAR_Command_Packaging/tests/make-rpm-spec test1.outtest1.phpt test_option_rpm-depname.out test_option_rpm-depname.phpt
test_option_rpm-pkgname.outtest_option_rpm-pkgname.phpt test_option_rpm-release.out test_option_rpm-release.phpt
References: 1 2  Groups: php.pear.cvs 
Request: Send a blank email to pear-cvs+get-38282@lists.php.net to get a copy of this message
On Thu, February 16, 2006 4:32 pm, Greg Beaver said: > The .out files should not be committed to cvs, Yes they should, but maybe I picked a bad naming convention. They're not temporary or auto-generated files; they are the main part of the tests and contain the "correct" (intended) output from the tests. However I'm happy to rename them to packagefiles/test-foo.spec if that makes people happier. > $phpunit->assertEquals(file_get_contents(dirname(__FILE__) . > DIRECTORY_SEPARATOR . 'packagefiles' . DIRECTORY_SEPARATOR . > 'PEAR::Net_SMTP-1.2.8.spec', file_get_contents($temp_path . > DIRECTORY_SEPARATOR . 'SPECS' . > DIRECTORY_SEPARATOR . 'PEAR::Net_SMTP-1.2.8.spec'), 'spec file > contents'); Except that this only works if you only have one test; even if I move the files to packagefiles/ they will still have to be called something like PEAR::Net_SMTP-1.2.8.spec-test_option_depname. Bear in mind the purpose of multiple tests is that the spec file output varies according to the options chosen, so I need multiple output files to test against. Any chance we can move this to pear-dev? I don't have the resources to subscribe to pear-cvs right now. T

« previous php.pear.cvs (#38282) next »