Re: Fwd: a PATCH to Net_SMTP-1.0 and update
| From: | Jon Parise | Date: | Thu, 02 Jan 2003 17:20:57 +0000 |
| Subject: | Re: Fwd: a PATCH to Net_SMTP-1.0 and update | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-12038@lists.php.net to get a copy of this message | ||
On Thu, Jan 02, 2003 at 11:12:37AM -0300, Damian Fernandez Sosa (DESC) wrote:
> Please dont commit those changes yet.
I've only committed the "off-by-one" bug fix in identifySender().
> If you like the way this functionality is coded, I'd like to add the following
> changes before you commit it:
Sounds good. In the future, please send specific diff's instead of an
entire file. A separate patch for each new piece of functionality
would be best.
--
Jon Parise (jon@php.net) :: The PHP Project (http://www.php.net/)