Re: Re: IT[X] fork, round 2

12 Февраль 2003 14:04, Pierre-Alain Joye написал: > On Wed, 12 Feb 2003 13:57:21 +0300 > > Alexey Borzov <borz_off@cs.msu.su> wrote: > > I might consider making patches, they won't be *that* small, > > although. But > > right now I have some strange feeling they will never be applied, so > > can't force myself to bother. > > As far that does not replace preg by default and there is no cache > feature, I do not see why we cannot apply them if they are good and do > not break BC. As for changing preg_replace() to str_replace() in variable substitution: it works faster and fixes an annoying bug, as Bertrand Mansion pointed out. As for the cache, it is a major new feature which greatly helps on high-traffic websites. I should even note that without it IT is unusable on such websites --- I have personal experience on this. The patches (for IT.php) can probably be done in 3 big chunks: 1) Refactoring patch: names, private methods and stuff. This patch will probably be the size of IT.php itself... 2) New features except caching: hideBlock(), setGlobalVariable() --- they influence the parse() method and some others. 3) Caching: this thing is pretty much an add-on and influences only the loadTemplateFile() method. But as this is open-source world, where everything is based on personal preferences, I'd rather spend my time on test suite for IT. Thus we would not only have a better package, but a better package with a test suite and a precedent.