Re: New package (PECL) proposal: IBM Websphere MQ (mqseries) - REPOST

On Fri, 16 May 2003, Michael Bretterklieber wrote: > Got 4 Votes from pear-dev, hopefuly I get the last vote from internals > (please, please, please, ...) :-) > > I changed some minor things (added comments, removed unneeded functions, > etc.) and added a .dsp => It now also builds under Windoze :-) I see a few problems: 1. All #include's should start on column 1. (see MINIT) 2. Under which licence is it? 3. Why is there still a Makefile.in? We don't use those anymore. 4. There is no tests directory for the php test framework. 5. The prototypes in the .c file for PHP_FUNCTION's always should be formatted like this: /* {{{ proto ressource mqseries_conn(string name) Connect to the Queue-Manager with the given name. You need either the Channel-Table (usualy in /var/mqm) or set the environment var MQSERVER=<channel>/<proto>/<host>[(port)] MQSERVER=example/TCP/mqs.example.com */ And not like: /* {{{ proto ressource mqseries_conn(string name) Connect to the Queue-Manager with the given Name You need either the Channel-Table (usualy in /var/mqm) or set the environment var MQSERVER=<channel>/<proto>/<host>[(port)] MQSERVER=example/TCP/mqs.example.com */ 6. _set_msg_desc_from_array is not a PHP function, so no proto there, and never use the _ as prefix as this is private compiler space. (An we usually put those function before we actually use them). That's the things I can see so far (except for some minor CS probs). regards, Derick -- "my other box is your windows PC" ------------------------------------------------------------------------- Derick Rethans http://derickrethans.nl/ PHP Magazine - PHP Magazine for Professionals http://php-mag.net/ -------------------------------------------------------------------------