Re: Re: New package (PECL) proposal: IBM Websphere MQ (mqseries) - REPOST

> 1. All #include's should start on column 1. (see MINIT) Okay, one small #include thingy. > 2. Under which licence is it? Did you read the source? That's clearly a BSD license. > 3. Why is there still a Makefile.in? We don't use those anymore. Okay, you're right. I only looked at the source itself. > 4. There is no tests directory for the php test framework. I didn't know we required them? > 5. The prototypes in the .c file for PHP_FUNCTION's always should be > formatted like this: > ... Okay, true. > 6. _set_msg_desc_from_array is not a PHP function, so no proto there, > and never use the _ as prefix as this is private compiler space. > (An we usually put those function before we actually use them). Okay, true again. Consider making them static. Some other minor inconsistancies: 7. In PHP_FUNCTION(mqseries_cmit) you mix RETVAL_* and RETURN_*: if (mqdesc->comp_code == MQCC_OK) { RETVAL_TRUE; } else { RETURN_FALSE; } 8. In PHP_FUNCTION(mqseries_error) and PHP_FUNCTION(mqseries_conn) you check if array_init() returns SUCCESS which is unnesesary. array_init() doesn't return if it something goes wrong. Sigh. Maybe it would help if we would such analysis over the main PHP source code too. Sander