Re: Re: New package (PECL) proposal: IBM Websphere MQ (mqseries) - REPOST

Hi, Sander Roobol schrieb:

1. All #include's should start on column 1. (see MINIT) Okay, one small #include thingy. fixed.

2. Under which licence is it? Did you read the source? That's clearly a BSD license. yes :-)

3. Why is there still a Makefile.in? We don't use those anymore. removed.

4. There is no tests directory for the php test framework. I didn't know we required them? I can write test cases, but in order to get these to work you need:

a) download, install, configure the MQ-Server (30 Days evaluation possible) b) download and install the MQ-Client + SDK c) configure the client (channel-table, MQSERVER env-var) otherwise any testcase will fail. and for a real test you need two scripts, one wich writes something in the queue and the other one wich reads the message.

5. The prototypes in the .c file for PHP_FUNCTION's always should be fixed.

6. _set_msg_desc_from_array is not a PHP function, so no proto there, and never use the _ as prefix as this is private compiler space. (An we usually put those function before we actually use them).

if forgot the static keyword, fixed

Some other minor inconsistancies: 7. In PHP_FUNCTION(mqseries_cmit) you mix RETVAL_* and RETURN_*: if (mqdesc->comp_code == MQCC_OK) { RETVAL_TRUE; } else { RETURN_FALSE; } fixed.

8. In PHP_FUNCTION(mqseries_error) and PHP_FUNCTION(mqseries_conn) you check if array_init() returns SUCCESS which is unnesesary. array_init() doesn't return if it something goes wrong. removed

bye, -- ------------------------------- ---------------------------------- Michael Bretterklieber - http://www.bretterklieber.com JAWA Management Software GmbH - http://www.jawa.at Tel: ++43-(0)316-403274-12 - GSM: ++43-(0)676-84 03 15 712 ------------------------------- ---------------------------------- "...the number of UNIX installations has grown to 10, with more expected..." - Dennis Ritchie and Ken Thompson, June 1972