Re: Package Proposal : DB_Dump

<mj@php.net> wrote : > On Sun Jun 01, 2003 at 06:3930AM +0300, indyone :o) wrote: >> My name is Ioannis and i have developed a new class which i'm >> calling it DB_Dump and as the name says, it has to do with the dumping >> the data of a database. >> This class needs PEAR::DB to work. The main uses of this class is to >> create a dump file of the tables of a database, and to execute a file >> with dumped data. >> To make this class possible i have used some functions from phpMyAdmin. >> The dumped data is also compatible with phpMyAdmin's dump files. >> >> I have the source here >> http://cassiopea.ee.teiath.gr/~indyone/dbdump/ > > After having read the code, it appears to me as if the code is pretty > much MySQL-centric, which isn't a good thing. Using DB::tableInfo() > instead of custom queries to acquire the information about the database > would probably help a lot. I agree with you Martin, unless this is called MySQL_DB_Dump or whatever saying more clearly it can only be used with MySQL. Then, I suggest the author doesn't use PEAR::DB at all to obtain faster results. The problem with tableInfo() right now is that it returns different info for each database. The returned info should be the same for every database if we really want this feature to be useful one day. Bertrand Mansion Mamasam