Re: fix to spaces in path

As I previously replied to you about your patch, I'm going to test it and commit if works. This stuff needs to be tested in several scenarios (make install, go-pear, under win, under linux), that's why I preffer to do it by my self and that's why I'm slow on putting my hands on the job. Thanks a lot, this spaces in path problem it's very annoying for windows users, I'll keep you informed. Tomas V.V.Cox On Saturday, August 2, 2003 20:27, Greg Beaver wrote: > This is your gadfly speaking. > I'd like to commit the patch that fixes the spaces in path issue. > Perhaps a show of hands in favor of fixing this problem would help move > things along? Here is a list of the problems with spaces in paths that > are solved by this fix: > - pear install to a subdirectory of "C:\Program Files" will not work. > "C:\Program Files" is the most commonly used install directory on windows > - pear package will not work in any subdirectory containing spaces, and > will create and possibly overwrite folders of the same name as the > suffix. So if you have 2 directories "C:\Web" and C:\Web Pages", the > pear package command will overwrite the contents of C:\Web and fail with > a cryptic error message about not being able to copy a random file with > .tmp pre-pended to it > - the new publicweb role which is proposed will not allow installation > to "C:\Program Files\Apache Group", the default Apache location on windows. > backwards compatibility issues: none - this patch is internal, and uses > pre-programmed features of the same functions to do the job. > API issues: none - no changes are visible to private or public > functions, no other code need be changed. > All in favor of fixing these bugs please +1, this will at least start > the ball rolling. > For those wishing to test or review this fix, I've attached the patch > Greg -- Tomas V.V.Cox mailto:cox@idecnet.com