Re: New Package Proposal: File_Ogg
| From: | Greg Beaver | Date: | Thu, 28 Aug 2003 21:45:11 +0000 |
| Subject: | Re: New Package Proposal: File_Ogg | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-20780@lists.php.net to get a copy of this message | ||
Hi David,
A comment:
in Vorbis.php, the constants should be named OGG_VORBIS_*, to reflect the Ogg-ness of Ogg_Vorbis. (It is not a separate top-level package named Vorbis)
Otherwise, my cursory look says this is well-documented code. You will probably benefit from subpackages when they get worked out, which is happening right now.
I have a conditional +1: commit to cvs, but don't do an initial release without really great docs at pear.php.net (don't use existing docs as a model :). I'm willing to be a doc beta-tester, as someone who knows nothing about Ogg_Vorbis, but a bit about documentation. My initial impression of Ogg_Vorbis is that it is an interesting technology, but since nobody uses it yet, this is a problem. As a professional musician myself, I'd like to see a short summary of the problem that Ogg solves (just excerpt something from http://www.xiph.org/about.html and link to it) in the introduction to the docs.
Regards,
Greg
David Grant wrote:
Hi List Members, This is a proposal for File_Ogg, a PEAR group of classes for accessing media information within an Ogg physical bitstream, to be added to PEAR. Sources can be found at: http://jalapeno.dyndns.org/File_Ogg/ together with the packaged source and a package definition file. File_Ogg is packaged with File_Ogg_Vorbis_PEAR (for an explanation of the PEAR suffix, check this mailing list for previous comments by myself and others on this package), which is a class for accessing Vorbis logical streams. It is anticipated that a number of other logical streams will become accessible in the near future. Comments and +1s (in that order) are very welcome. Cheers, -D.