Re: Request for comments on Unitests for Net_FTP

Tobias Schlitt wrote:

Sorry, for the lame last mail. I hit the button accidentally. <zitiere wer="Wolfram Kriesing">

first thing, there was a discussion on pear-qa a week ago or so, about passing i.e. a DB-DSN. I suggested that you can provide a simple URL-GET parameter that the unittest needs, if not given either fallback or show a warning. That would also be useable (with sligh modifications) for later automatic tests, which are called via commandline.

Do you think, sending all those parameters through GET is comfortable? These are: a) host b) (port) c) user d) password e) file to upload f) file to download g) directory to upload h) directory to download Thats a bit to much I think, isn't it?

wouldnt that be somehow like this: url.php?dsn=user:password@host:port/directory where the directory is a public directory, which means you need to be able to up- and download to this dir. You would of course have to upload the file first in order to download it, which might not be perfect in this case, but wouldnt that work? I am not to deep in it, just telling my thoughts :-)

About testing the FTP if no server is available. Would Mock objects be a help here? Might not be too easy to implement ... just a thought

Sorry, I got no idea how to implement that, because the class uses PHPs internal FTP functions... :(

-- Wolfram ... opensource @ vision:produktion ... http://opensource.visionp.de ... authentication system .... http://sf.net/projects/auth