Re: [PATCH] HTTP_request
| From: | Richard Heyes | Date: | Thu, 02 Oct 2003 18:38:32 +0000 |
| Subject: | Re: [PATCH] HTTP_request | ||
| References: | 1 2 3 4 5 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-22327@lists.php.net to get a copy of this message | ||
> 1) A patch I sent to Richard a lo-o-ong time ago to make appending [] to
> variables optional (like the one that was applied to Net_URL)
Can't remember for sure, but I beleive I rejected this.
> 2) File upload patch (your own!):
>
> http://marc.theaimsgroup.com/?l=pear-dev&m=104799891514924&w=2
Not looked at this.
> 3) Stefan Walk's patch to implement Observer pattern and to do a lot of
other
> stuff.
Not seen this.
> 4) I received a patch for 100-Continue response handling for HTTP_Client.
I
> suspect it'll be better to implement this in HTTP_Request.
Sounds Ok.
===========================================================
>
> I can work on integrting the patches and preparing a new major release of
> HTTP_Request, as its current state limits the possibilities of development
for
> my own HTTP_Client.
As long as the code is good quality, and previously rejected patches aren't
applied, then this shouldn't be a problem. Also, I wouldn't want to see
HTTP_Request becoming bloated due to requirements in HTTP_Client, if you
know what I mean.
> There is also a problem with redirection support in HTTP_Request. My
personal
> POW is that redirection does not belong to the package at all and its
addition
> was a BC break done in a minor 1.1.1 release.
Too late, it's in there now.
--
Richard Heyes
http://www.v-webmail.org