[PEPr] Comment on XML::XML_XUL
| From: | PEPr | Date: | Mon, 23 Feb 2004 00:32:17 +0000 |
| Subject: | [PEPr] Comment on XML::XML_XUL | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-25785@lists.php.net to get a copy of this message | ||
Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for XML::XML_XUL.
Comment:
Not bad..
couple of things:
- too many 'empty' classes.. - why not store the schema (eg. attributes types in a
'data' file), and just use base XML_XUL_Element...
A few of the methods use >3 arguments.. it would be nice to simplify them, or start using the
assoc array method of setting..
I would prefer
$tb = XML_XUL_Element::Factory('textbox');
And please, please, please make the children/attributes public.. vars..
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=22
--
Sent by PEPr, the automatic proposal system at http://pear.php.net