Re: Re: DB::modifyLimitQuery() - 4th parameter??

On Thu, 25 Mar 2004 12:33:45 -0500, Daniel Convissor wrote: > On Thu, Mar 25, 2004 at 05:30:15PM +0100, Lorenzo Alberton wrote: >> AFAIK, both DB_DataObject and DB_QueryTool (i.e. two packages >> *tightly* tied to PEAR::DB) use that method, > > Oy. That's a different story then. DB_DataObject has a declared > dependency on DB. I've updated CVS thanks a lot > and notified Alan, who maintains DB_DataObject. > > DB_QueryTool unfortunately does not, though it does depend on Log > which then depends on DB. Seems it would be wise for it to > directly declare a DB dependency, particularly if it's going to the > lengths of using private methods. No? What do others think? I didn't notice... I will fix it right now. > Also, what do folks think about packages using private methods of > other packages? Shouldn't private methods only be used by the > package they belong to? in an ideal world, yes. But I think an exception could be made for those methods that can be useful outside the internal mgmt too, at least for tightly tied classes like the two mentioned above. What about declaring that method protected? Alternatively, is there a way to reach the same goals without using that method? I'm sorry but I know MDB way better than DB, so any hint about this matter is appreciated. >> BTW: mysql4.php has only 3 params. > mysql4.php has been replaced by mysqli.php. Blow away the old file. oh, sorry. Thanks again Lorenzo