Re: Re: DB::modifyLimitQuery() - 4th parameter??

Hi Daniel, first of all, thanks for the reply On Thu, 25 Mar 2004 11:05:30 -0500, Daniel Convissor wrote: >> what is the 4th parameter of DB::modifyLimitQuery() >> meant to do? I don't see it used in any driver, > > The fourth argument is indeed used in some drivers. It comes into > play when a user tries to use limitQuery() on prepared/executed > query. ah, yes, that'd be oracle. I hadn't seen it. >> and since it has not a default value it breaks >> packages depending on it... > > modifyLimitQuery() is a private class. Packages should not be > calling it directly. If they are, that's not our problem. that's fair... ;-) However, my point is: since it's only used by ONE driver, why don't you add a default value for that mostly unused parameter (at least for the other drivers), and keep BC? ==== function modifyLimitQuery($query, $from, $count, $params=null) ==== AFAIK, both DB_DataObject and DB_QueryTool (i.e. two packages *tightly* tied to PEAR::DB) use that method, so both packages will raise warnings because of that. Of course I'm open to suggestions on alternatives. BTW: mysql4.php has only 3 params. Best regards, Lorenzo