Re: Re: coding standards: Header Comment Blocks

Hi Daniel Convissor! On 06/16/04 02:01 you wrote:

I'm working on the next draft for this header comments RFC.

A lot of folks were interested in seeing one of the phpDocumentor docblock @version tags contain the package release number as determined by the PEAR installer's replacement on @package_version@.

While this sounds nice, I have some reservations. They didn't seem to be addressed, so I'd like to follow up.

As mentioned before, it would force putting replace tags for each file into the package.xml file. I'm wondering why the installer doesn't just do the search/replace automatically without prompting from the package.xml. Similarly, why do the replacements while during the packaging, rather than the installing? (Let alone during packaging without prompting from the package.xml file.) (I have a feeling this has all been discussed before. :) )

Not that I know of. :) IMHO it's not the best to change the installer like this. Maybe there will exist channels you don't want to use that feature (don't know why, but users sometimes want to do the strangest things). Having it automatically added by the PackageFileManager (and introducing an option to switch it off) is a better way.

Next, since the pacakging process can/does produce md5 sums for each file, doesn't the replacement upon installation cause the files' md5's to not match the recorded ones?

AFAIK the md5 check is processed before replacement. Regards, Toby -- Tobias Schlitt GPG Key: 0xA6529579 a passion for php http://www.schlitt.info