Re: Call for test: Comment system - II
| From: | Aidan Lister | Date: | Thu, 24 Jun 2004 08:13:08 +0000 |
| Subject: | Re: Call for test: Comment system - II | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-31407@lists.php.net to get a copy of this message | ||
One last comment, I promise.
On the pear.comments list I see the emails have an extra newline at the
start. I assume this is because stephan is using the Mail class which still
has this bug?
When will that be fixed!?
"Christian Wenz" <wenz@php.net> wrote in message
news:40E3B003.4050108@php.net...
> Hi,
>
> > Hi all!
> >
> > I (hopefully) fixed the encountered bugs. I still get a weired
> > behaviour with htmlentities(), cause irregularly there occur "\n"'s,
> > where only a normal space is. Will check that tomorrow.
> >
> > The environment is working so far, so further tests are welcome!
> >
>
> great stuff! Some comments:
>
> * I submitted
>
> http://zuhause.bei.tobias-schlitt.de:81/comments/view.php?id=61&insert=1
> . However I was also able to have a look at
>
> http://zuhause.bei.tobias-schlitt.de:81/comments/view.php?id=60&insert=1.,
> for instance. Especially if an offensive comment is entered, it is a bad
> idea (TM) to make this visible for the curious ones.
> * There should separate input fields for email and name, like on
> php.net/manual.
> * I am also getting the \n's instead of spaces. Maybe adding
> wrap="virtual" to the <textarea> helps, but honestly I am not sure, it
> could also be an automatic breaking of long lines.
> * Using <pre> on view.php is probably not a good idea (TM, again), since
> in that case longer lines are not wrapped automatically (see id=61).
>
> Best,
> Christian