Re: Call for test: Comment system - II

Hi Christian Wenz! You wrote: > great stuff! Some comments: > * I submitted > > http://zuhause.bei.tobias-schlitt.de:81/comments/view.php?id=61&insert=1 > . However I was also able to have a look at > > http://zuhause.bei.tobias-schlitt.de:81/comments/view.php?id=60&insert=1., > for instance. Especially if an offensive comment is entered, it is a bad > idea (TM) to make this visible for the curious ones. Right, these should be viewable only when logged in (as long as they aren't approved). Will change that this evening. > * There should separate input fields for email and name, like on > php.net/manual. Mhhh... AFAIK they only ask 1 thing. <snip>Your email address (or name):</snip> I'm very in favor of that, since people are not forced to submit their email address. > * I am also getting the \n's instead of spaces. Maybe adding > wrap="virtual" to the <textarea> helps, but honestly I am not sure, it > could also be an automatic breaking of long lines. Will have to dig deeper in that... > * Using <pre> on view.php is probably not a good idea (TM, again), since > in that case longer lines are not wrapped automatically (see id=61). True. I will either change that to a div with adequate CSS or do a manula wrapping in PHP. Thanks for your feedback! Regards, Toby -- Tobias Schlitt GPG Key: 0xA6529579 a passion for php http://www.schlitt.info Like to say "thank you"? - http://pear.php.net/wishlist.php/toby