[PEPr] +1 for Database::DB_odbtp

From: Date: Thu, 09 Sep 2004 15:23:06 +0000
Subject: [PEPr] +1 for Database::DB_odbtp
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-33317@lists.php.net to get a copy of this message
Daniel Convissor (http://pear.php.net/user/danielc) has voted +1 on the proposal for Database::DB_odbtp. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=144 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=144&handle=danielc This vote is conditional. The condition is: Addressing other's concerns, having this as a standalone pacakge is fine by me. In general, the code looks really good. Thanks. I don't like how the 'username' DSN element contains all of this information: $dsninfo['username'] = 'DRIVER={Microsoft Access Driver (*.mdb)};DBQ=c:\NorthWind.mdb;UID=admin;PWD=;'; That needs to be broken down into the proper elements in order to provide portability/comprehendability with DB. The var declarations need to be on separate lines and need docblocks. All methods need docblocks In the class-level docblock, shouldn't the @package be DB_odbtp? Please clean up the docblock formatting for getSpecialQuery(). -- Sent by PEPr, the automatic proposal system at http://pear.php.net

« previous php.pear.dev (#33317) next »