Re: [PEPr] +1 for Database::DB_odbtp

> This vote is conditional. The condition is: > > Addressing other's concerns, having this as a standalone pacakge is fine by me. > > In general, the code looks really good. Thanks. > That's because I used DB_mssql as a model. :) Also, in case you didn't know, the odbtp/mssql hybrid extension can be used in place of the mssql and sybase extensions to support DB_mssql. This will allww DB_mssql to process UNICDOE data and/or queries, and varchar(>255) data on all platforms. > I don't like how the 'username' DSN element contains all of this information: > $dsninfo['username'] = 'DRIVER={Microsoft Access Driver > (*.mdb)};DBQ=c:\NorthWind.mdb;UID=admin;PWD=;'; > That needs to be broken down into the proper elements in order to provide > portability/comprehendability with DB. > The odbtp extension prvoides 2 methods for connecting to a database via an ODBTP server. The first method directly connects to the ODBTP server, while the second indirectly connects to the server using an interface file. The second method permits complete portability/compatibiltiy with DB's connection scheme, and is therefore the preferred method. The first method is a bit more complicated, because it requires the specification of an ODBC driver connect string that is passed directly to the ODBTP server. Such a string cannot be easily broken down to match DB's paradigm. The reason is because it varies greatly between ODBC drivers, and may contain parameters that aren't accomodated. The first method uses 'hostspec' for the hostname or IP address of the ODBTP server, which is appropriate. 'username' was chosen for the ODBC driver connect string because it paps directly to the odbtp_connect() function's second parameter. This is important, because odbtp_connect will use the first method if it determines that the second parameter is an ODBC driver connect string. The use of the second method will be emphasized in the DB_odbtp docs. For more details about odbtp interfaces, see http://odbtp.sourceforge.net/interface.html. > The var declarations need to be on separate lines and need docblocks. > All methods need docblocks > > In the class-level docblock, shouldn't the @package be DB_odbtp? > > Please clean up the docblock formatting for getSpecialQuery(). > Will do. -- bob