[PEPr] Comment on HTML::HTML_QuickForm_SelectFilter

Justin Patrin (http://pear.php.net/user/justinpatrin) has commented on the proposal for HTML::HTML_QuickForm_SelectFilter. Comment: There should be spaces around the '=' in the constructor declaration. I personally don't like heredocs. I'd rather you use ' for the string and change str == '' to str == "" within the JS. You have: this.form[\''.$target.'\'] would this be cleaner? this.form["'.$target.'"] As long as it *works*, of course, but any quotes should work. Again here: "<script type=\"text/javascript\">\n//<![CDATA[\n" could be: "<script type='text/javascript'>\n//<![CDATA[\n" or: '<script type="text/javascript"> //<![CDATA[ ' I prefer HTML_QuickForm_SelectFilter as the class name. Yes, it's different from the other QF elements, but it conforms to PEAR CS correctly. QF shouldn't have a problem with this class name as it doesn't do any caps changing on the class name or include filename. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=175 -- Sent by PEPr, the automatic proposal system at http://pear.php.net