Re: PHP_Archive Last call for comments before vote!

Hi Davey, you wrote: > I am now ready to Cfv on PHP_Archive, I fell I've done enough work for > you to cast an informed vote on the package. I'm looking forward to the first release of PHP_Archive! Just a few notes: - please use "isset()" instead of "!is_null()" isset is generally perferrable than any is_null call... - although the creator might most probably not be subject to class inheritance one should use "MyClass::__construct()" instead of "$this->__construct()" to ditch potential misbehaviour > 3) Make it compress, if anyone would care to look over the Archive.php > file and tell me why the FUCK its not working, that would be great. It > just doesn't seem to work - no errors! So, is the linked package file up to date? Regards, -- Michael - < mike(@)php.net >

Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc