Re: PHP_Archive Last call for comments before vote!

Michael Wallner wrote:

Hi Davey, you wrote:

I am now ready to Cfv on PHP_Archive, I fell I've done enough work for you to cast an informed vote on the package.

I'm looking forward to the first release of PHP_Archive! Just a few notes: - please use "isset()" instead of "!is_null()" isset is generally perferrable than any is_null call...

I do this for a reason. Personal style and all that :)

- although the creator might most probably not be subject to class inheritance one should use "MyClass::__construct()" instead of "$this->__construct()" to ditch potential misbehaviour

You know, this is smart. Damn, wish someone had pointed this out *much* sooner. Oh well, one more reason to jump ship to PHP5 (which I have done) ;)

3) Make it compress, if anyone would care to look over the Archive.php file and tell me why the FUCK its not working, that would be great. It just doesn't seem to work - no errors!

So, is the linked package file up to date?

Indeed, 0.4.0 is the latest code, I haven't modified it since then. Though I have been asking around for a solution. Greg has come up with a very neat idea, regarding PEAR, we'll see how that pans out too.

Regards,

- Davey