Re: Re: Working Version of Net_Monitor - Please Review :)

Bertrand Mansion wrote:

bertrand Gugger wrote:

$ps_host here acts poorly as mnemonic. I really prefer $this->_results[$i]['code']

Are you being serious ? Yes, I am, really. A difference is perhaps I have read and analyzed the code.

A method can get a property of $this as parameter, it's sometimes very usefull, here, as nothing could give such an idea, I actually mean this $primary of the function stateDiff($primary,$secondary) { (please read & understand the code there) is never needed and even dangerous.

I don't think people who write the code actually care if YOU are able or not to memorize the variable names as long as they can themselves maintain their packages :) I think the people indeed prefer that YOU say: "yes, it's wonderfull"

without reading the code, so YOU are right, and i don't. à++positive -- bertrand Gugger (toggg)