[PEPr] Comment on HTML::HTML_FormPersister
| From: | Alan Knowles | Date: | Tue, 18 Jan 2005 01:50:11 +0000 |
| Subject: | [PEPr] Comment on HTML::HTML_FormPersister | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-35574@lists.php.net to get a copy of this message | ||
Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for
HTML::HTML_FormPersister.
Comment:
The concept is quite interesting (it's basically how flexy's element stuff
works in principle)
however the implenentation has some serious questionable issues:
a) parsing HTML with regex seems like a recipe for disaster... (the parser
package)
- HTML Tidy?, google flexyparser / look at Flexys HTML parser.
b) performance of a non-cache based solution would be very questionable.
(consider some kind of compiled solution?)
c) this totally breaks the seperation of input and rendering.. (think of
the end user manually giving the package the input data, rather than it
reading it directly.)
d) the extending parser design makes the code very difficult to follow,
registing callbacks may be clearer
e) actually running the code from the include is very naughty - it stops
the code be used as a library.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=193
--
Sent by PEPr, the automatic proposal system at http://pear.php.net