[PEPr] -1 for Tools and Utilities::Util_Array
| From: | Alan Knowles | Date: | Tue, 18 Jan 2005 13:27:27 +0000 |
| Subject: | [PEPr] -1 for Tools and Utilities::Util_Array | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-35581@lists.php.net to get a copy of this message | ||
Alan Knowles (http://pear.php.net/user/alan_k) has voted -1 on the proposal for Tools and
Utilities::Util_Array.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=190
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=190&handle=alan_k
Comment:
While there is some value in this, There are a number of problems which
justify a -1
- there were no comments during the proposal period, It would have been
better to announce on pear-dev that you intended to move it to voting.
- the grouping of utilities to files/classes seems mixed and vague.
- Some appear redundant (some methods could easily be replaced with a
clever array_walk/create_function call)
- CS standard are not followed, method names/ class names, etc. { }
placement
- some of the code has very redundant else /elseif structures.
It may be worth considering some of this within a Util_Array class, rather
than singular Array_* classes
--
Sent by PEPr, the automatic proposal system at http://pear.php.net