Re: [PEPr] -1 for Tools and Utilities::Util_Array

Alan Knowles wrote: > Alan Knowles (http://pear.php.net/user/alan_k) has voted -1 on the proposal for Tools and Utilities::Util_Array. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=190 > Vote information: > http://pear.php.net/pepr/pepr-vote-show.php?id=190&handle=alan_k > > Comment: > > While there is some value in this, There are a number of problems which > justify a -1 > - there were no comments during the proposal period, It would have been > better to announce on pear-dev that you intended to move it to voting. > > First comment: I glad :-) Unfortunately, I can't send e-mails to list because my hosting provider in SpamHouse blacklist. (The hosting provider can't remove self from blacklist, because SpamHouse asks they 50$ for every e-mail from their customer who have sended spam. For virtual hosting it is impossible, IMHO) So I'll answer here. > - the grouping of utilities to files/classes seems mixed and vague. > - Some appear redundant (some methods could easily be replaced with a > clever array_walk/create_function call) > - CS standard are not followed, method names/ class names, etc. { } > placement > > Yes, but I have tried to imitate inner PHP functions like array_search etc. Replace? > - some of the code has very redundant else /elseif structures. > > Which? From Array_Find class? They were created for more variable behavior. Replace they with switch? > It may be worth considering some of this within a Util_Array class, rather > than singular Array_* classes > > I have thinked about, but in PEAR manual I read about creating new category is not good practice. Any case, which routines you like? -- S uvazheniem, Sveta Smirnova Best regards, sorry for English, Sveta Smirnova mailto:sveta@microbecal.com Вы уже с Yahoo!? Yahoo! Почта - объем ящика больше, чем у других! http://ru.mail.yahoo.com