[PEPr] Comment on Encryption::Crypt_Blowfish

Alan Knowles (http://pear.php.net/user/alan_k) has commented on the proposal for Encryption::Crypt_Blowfish. Comment: Just a few points * defining 'N' should not be done all defines should be prefixed CRYPT_BLOWFISH_* * private methods should be prefixed with _ * It may be worth using more descriptive method and property names than P,N etc. * I'm not sure if loading the default crypt keys from a file might be better (removes alot of noise from the code) * removing @ wrappers is prefered practice (you will get bug reports from people complaing about it ;) Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=208 -- Sent by PEPr, the automatic proposal system at http://pear.php.net