Re: [PEPr] Changes in proposal for Encryption::Crypt_Blowfish

From:	Davey	Date:	Tue, 08 Feb 2005 22:39:09 +0000
Subject:	Re: [PEPr] Changes in proposal for Encryption::Crypt_Blowfish
References:	1 2	Groups:	php.pear.dev
Request:	Send a blank email to pear-dev+get-36076@lists.php.net to get a copy of this message

Matthew Fonda wrote:

Matthew Fonda (http://pear.php.net/user/mfonda) has edited the proposal for Encryption::Crypt_Blowfish. Change comment: * removed @ wrapper from ord * added class Crypt_Blowfish_Default_Key which contains the default key * Crypt_Blowfish now initializes using Crypt_Blowfish_Default_Key object Please review the proposal: http://pear.php.net/pepr/pepr-proposal-show.php?id=208

I would suggest using Crypt_Blowfish_DefaultKey so that you don't have: Crypt/

     Blowfish/
             Default/
                    Key.php

Rather: Crypt/

     Blowfish/
             DefaultKey.php

Of course, I haven't read the code and if you have some Crypt_Blowfish_Default(_*) class already then ignore this ;) - Davey