Re: [PEPr] Changes in proposal for Encryption::Crypt_Blowfish
| From: | Ants Aasma | Date: | Wed, 09 Feb 2005 21:02:58 +0000 |
| Subject: | Re: [PEPr] Changes in proposal for Encryption::Crypt_Blowfish | ||
| References: | 1 2 3 4 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-36106@lists.php.net to get a copy of this message | ||
Michael Wallner wrote:
<plug> Well, sorry for jumping in, but would you mind looking at File_Passwd::crypt_apr_md5()? ;-) That would definitly need some reasonable optimization... it takes about .25s for one passwd. </plug>Ok, here you go, diff against File_Passwd 1.1.2 http://www.hot.ee/stepz/Passwd.php.diff Old one: 83ms New one: 8.3ms :) I could squeeze another 60% of performance out of it at 5.1ms by taking the version check out of the main loop, composing the md5 argument inline and taking the concatenations out of the loop, but that looked godawful. You be the judge if the performance is worth the code readibility. Diff's @ http://www.hot.ee/stepz/Passwd.php.diff2 ------ Ants