[PEPr] Comment on Math::Math_Finance
| From: | Jesus M. Castagnetto | Date: | Mon, 28 Mar 2005 20:46:14 +0000 |
| Subject: | [PEPr] Comment on Math::Math_Finance | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-36909@lists.php.net to get a copy of this message | ||
Jesus M. Castagnetto (http://pear.php.net/user/jmcastagnetto) has commented on the proposal for
Math::Math_Finance.
Comment:
Overall I like the code (mind you that I've gone over it quickly).
There are some fixable code issues mentioned by others, and I'd like to
add that you might have the singleton class in separate file. As you
expand the code, it might make it simpler to add things if you have a
class per file.
Apart from these minor things, the package looks good.
BTW, if you want to, check out a kludgy package I made some time ago (and
that I've ex professo put on my site today), which computes statistical
index numbers common in finance, etc.
The URL for that package is:
http://www.castagnetto.org/pear/Math_StatIndex-0.5.0.tgz
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=225
--
Sent by PEPr, the automatic proposal system at http://pear.php.net