Re: [PEPr] +1 for XML::XML_Feed_Parser
| From: | Arnaud Limbourg | Date: | Sun, 23 Oct 2005 21:01:01 +0000 |
| Subject: | Re: [PEPr] +1 for XML::XML_Feed_Parser | ||
| References: | 1 2 3 4 5 6 7 8 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-40264@lists.php.net to get a copy of this message | ||
anatoly techtonik wrote:
||*()*|| [\..konnichi wa, ogenki desu ka, Arnaud../]AL> As far as I can see Coding Standards do not say you should use AL> concatenation over inlining, end of the story. Some arguments were given AL> in favor of the former, in the end the developer decides which form to use. It would be nice this conslusion to be included as notice in CS, so developers will not spot debates over and over again. Another thing (rather unusual for me) I'd like to see there - "respect to other's coding style if it is not is described in CS". I have always thought this to be implicit but I can see the use of clarifying.
Here is the patch for review and rephrase. Although I can commit it I afraid my touch of this sacred text can be considered chaotic act resulting in immediate prosecution. =) Please open a bug report with a link to the patch, Coding Standards changes can border on religious war so better take a bit of time ;)Thanks, Arnaud.