Re: [PEPr] +1 for XML::XML_Feed_Parser

Hello Justin, From Monday, October 3, 2005, 7:05:46 PM, you wrote: JP> This vote is conditional. The condition is: JP> Please use ' instead of " for any strings which do not have JP> backslash expressions (\n) or variables in them. What for? =/ JP> Please create and use a new Exception class for this package JP> which extends PEAR_Exception (see Matthew's comment). JP> Please don't add try/catch blocks which only catch and JP> re-throw exceptions. This is useless and confusing. (Such as in JP> Parse.php __construct(), but I also saw this in most of the other JP> files) JP> Please use true instead of TRUE. Justin, are you going to maintain that package? If not when why if smb. is more comfortable with style not covered by CS (thanks god) - why should (s)he waste time by doing this? You guys are crazy on this stuff. JP> (Optional) JP> I would prefer using ' for all strings except those with JP> backslash expressions as variable interpolation is more expensive JP> and less visible than concatenation. JP> Please use ++$var instead of $var++ unless you must use a JP> post ++. Prepending it is slightly more efficient and is less JP> prone to error. Very convincing. Do you have some grounds to study? JP> The valid() function in Parser.php could be replaced with: return $this->>current_item < $this->feed->numberEntries; Justin, it is not your job. Why are you so mad about it? P.S. http://www.blueshoes.org/phpBench.php "PEAR" - Powerful Establishment of Advices and Regulations t --