[PEPr] Comment on XML::XML_Feed_Parser

Arnaud Limbourg (http://pear.php.net/user/arnaud) has commented on the proposal for XML::XML_Feed_Parser. Comment: First off: Nice work ! Now onto comments :) The link to the PEAR package on the page is broken (i mean this page http://dev.jystewart.net/XML_Feed_Parser/. You might want to have a custom exception class extending PEAR_Exception or throw a PEAR_Exception. In XML_Feed_Parser constructor I would use a switch rather than elseif for feed type detection. Having that in another method altogether might even make more sense (just a thought). In Atom.php there is a require statement at the very bottom of the script, should be at the top. I get PHP Fatal error: Call to protected method XML_Feed_Parser_Type::getCategory() from context '' example.php line 22 Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=295 -- Sent by PEPr, the automatic proposal system at http://pear.php.net