[PEPr] Comment on Math::Math_Polynomial (Re-proposal)
| From: | bertrand Gugger | Date: | Fri, 16 Dec 2005 16:19:00 +0000 |
| Subject: | [PEPr] Comment on Math::Math_Polynomial (Re-proposal) | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-40758@lists.php.net to get a copy of this message | ||
bertrand Gugger (http://pear.php.net/user/toggg) has commented on the proposal for
Math::Math_Polynomial (Re-proposal).
Comment:
Looks good ...
* you must require 'Math/Polynomial.php'; not 'Polynomial.php', same for
the other files and test.
* perhaps let the possibility to the user to define
MATH_POLYNOMIAL_ROUND_BOUNDARY (if (!defined(...))) ?
* please, don't return PEAR::raiseError() in a method intended to return a
reference, it breaks php5.
* same for return new class(), you must use an intermediate variable.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=332
--
Sent by PEPr, the automatic proposal system at http://pear.php.net